C#: Fix CFG for unknown expressions#11
Merged
Merged
Conversation
Contributor
calumgrant
commented
Aug 3, 2018
calumgrant
commented
- Fix the CFG for unknown expressions, which were previously excluded from the control flow graph, which could lead to an incomplete graph.
- Add a test for this change, and also test the extraction of initializer-lists with unknown expressions. This test will currently fail on this branch as it tests extractor changes.
calumgrant
force-pushed
the
cs/standalone-cfg-fixes
branch
from
8e311a2 to
3658185
Compare
hvitved
requested changes
Aug 14, 2018
| * Returns the `i`th child of an expression, with | ||
| * children ranked from 0. | ||
| */ | ||
| private ControlFlowElement getRankedExprChild(Expr e, int i) { |
Contributor
There was a problem hiding this comment.
I would change the name to getUnknownExprChild to match the other helper predicates, and perhaps remove the QL doc.
| * Returns the `i`th child of an expression, with | ||
| * children ranked from 0. | ||
| */ | ||
| private ControlFlowElement getRankedExprChild(Expr e, int i) { |
Contributor
There was a problem hiding this comment.
Change Expr e to @unknown_expr, otherwise we will be computing the relation for all expressions, rather than just the unknown expressions.
| * have a valid `toString()`. | ||
| */ | ||
| class UnknownCall extends MethodCall | ||
| { |
| @@ -0,0 +1,18 @@ | |||
| import csharp | |||
Contributor
There was a problem hiding this comment.
Add a
/**
* @kind graph
* @id cfg
*/
header; then we will be able to see the visualized graph in the IDE.
Contributor
There was a problem hiding this comment.
Should be removed again, sorry.
calumgrant
force-pushed
the
cs/standalone-cfg-fixes
branch
3 times, most recently
from
4c5436e to
ff44772
Compare
Contributor
|
@calumgrant : Should this go into 1.18? |
Contributor
Author
|
It should be in sync with the corresponding changes in Semmle/code (https://git.semmle.com/Semmle/code/pull/26692), so yes. I'll rebase, but it will conflict with #163. |
…object initializer lists fixed by the extractor.
calumgrant
force-pushed
the
cs/standalone-cfg-fixes
branch
from
ff44772 to
ecb3efb
Compare
hvitved
approved these changes
Sep 10, 2018
Contributor
|
Does this need a change note, or doesn't the change affect existing users? |
smowton
pushed a commit
to smowton/codeql
that referenced
this pull request
Oct 28, 2021
Java/Kotlin: Enhance 'compilations' support
dbartol
pushed a commit
that referenced
this pull request
Dec 18, 2024
feat(composite-actions): Fix summary and source queries for composite actions analysis
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.